Skip to content

Fix regression from lazy opaque types #93783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix regression from lazy opaque types #93783

merged 1 commit into from
Feb 9, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 8, 2022

The breakage was found in #92007 (comment) and has not hit nightly yet.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 8, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2022
@oli-obk oli-obk mentioned this pull request Feb 8, 2022
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk oli-obk force-pushed the lazy_tait_regression_fix branch from 6c47458 to 239f1e7 Compare February 8, 2022 17:01
@Mark-Simulacrum
Copy link
Member

@bors p=1 rollup=never as this fixes broken perf, but I don't feel comfortable approving this myself right now.

@jackh726
Copy link
Member

jackh726 commented Feb 8, 2022

@bors r+

This is hacky, but I think better to land this and come up with a better fix than to let this hit nightly.

@bors
Copy link
Collaborator

bors commented Feb 8, 2022

📌 Commit 239f1e7 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2022
@bors
Copy link
Collaborator

bors commented Feb 8, 2022

⌛ Testing commit 239f1e7 with merge 97a8e8b5b5eec9a7cc44b553855cfe3c5dfd421e...

@bors
Copy link
Collaborator

bors commented Feb 8, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (50/59)
........  (59/59)


/checkout/src/test/rustdoc-gui/search-filter.goml search-filter... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:45

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 8, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2022
@lqd
Copy link
Member

lqd commented Feb 8, 2022

note for t-infra and tracking, the retry was because of #93784

@bors
Copy link
Collaborator

bors commented Feb 8, 2022

⌛ Testing commit 239f1e7 with merge cc38176...

@bors
Copy link
Collaborator

bors commented Feb 9, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing cc38176 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 9, 2022
@bors bors merged commit cc38176 into rust-lang:master Feb 9, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 9, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cc38176): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@ehuss ehuss mentioned this pull request Feb 9, 2022
Closed
@oli-obk oli-obk deleted the lazy_tait_regression_fix branch February 10, 2022 15:49
This was referenced Feb 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
10 participants
@oli-obk @rust-highfive @rust-log-analyzer @Mark-Simulacrum @jackh726 @bors @lqd @rust-timer @petrochenkov @rustbot